[FIX] CAS does not share secrets when operating multiple server instances #8654
+35
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Signed CLA + fixed email settings. |
AmShaegar13
force-pushed
the
fix-cas-with-multiple-instances
branch
2 times, most recently
from
4c00da7 to
8e7f2c9
Compare
|
AmShaegar13
changed the title
AmShaegar13
force-pushed
the
fix-cas-with-multiple-instances
branch
from
8e7f2c9 to
b49706d
Compare
…of process to fix CAS when operating multiple server instances
AmShaegar13
force-pushed
the
fix-cas-with-multiple-instances
branch
from
b49706d to
d6ee11b
Compare
AmShaegar13
changed the title
|
@rodrigok ready to merge. |
rodrigok
approved these changes
Dec 8, 2017
rodrigok
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #8032
This fixes CAS login when running multiple instances of RocketChat. When using CAS, a so called credentialsToken is stored in the server process to identify login attempts via CAS pop-up. This is bad when it comes to running several instances of RocketChat because it can not be guaranteed to hit the same instance again. Thus, I changed storing those tokens in MongoDB. In addition, I added a cleanup mechanism to delete outdated tokens of failed login attempts.